| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Devrim Gündüz <devrim(at)gunduz(dot)org> |
| Subject: | Re: [PATCH] Skip llvm bytecode generation if LLVM is missing |
| Date: | 2020-03-15 01:28:08 |
| Message-ID: | CAMsr+YFxmebADet3AERsQL7HakOXOzKzdsRKaZbfoqKoko9QmQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 13 Mar 2020 at 15:04, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2020-03-13 14:08:12 +0800, Craig Ringer wrote:
> > The alternative would be to detect a missing clang and emit a much more
> > informative error than the current one that explicitly suggests retrying
> > with
> >
> > make with_llvm=no
> >
> > or setting with_llvm=no in the environment.
>
> That, that, that's what I suggested upthread?
>
Yes, and I still don't like it. "with_llvm" is the actual already-working
option. I'd rather make this not randomly explode for users, but failing
that we can just hack the Makefile in the rpms for EL-7 (where it's a
particular mess) and rely on an error message for other cases.
--
Craig Ringer http://www.2ndQuadrant.com/
2ndQuadrant - PostgreSQL Solutions for the Enterprise
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-03-15 01:48:02 | Re: Additional improvements to extended statistics |
| Previous Message | Tomas Vondra | 2020-03-15 00:08:09 | Re: Additional improvements to extended statistics |