| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, konstantin knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru> |
| Subject: | Re: [PATCH] Logical decoding support for sequence advances |
| Date: | 2016-03-02 07:05:30 |
| Message-ID: | CAMsr+YFv5oFnk=1qkSoCeSGPRiO742Lh8CWB4DPsdA3nSth-=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1 March 2016 at 05:30, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>
> On 29/02/16 03:23, Craig Ringer wrote:
>>
>>
> Sound reasonable?
>>
>
> I wonder if it would be acceptable to create new info flag for RM_SEQ_ID
> that would behave just like XLOG_SEQ_LOG but would be used only for the
> nontransactional updates (nextval) so that decoding could easily
> differentiate between transactional and non-transactional update of
> sequence and then just either call the callback immediately or add the
> change to reorder buffer based on that. The redo code could just have
> simple OR expression to behave same with both of the info flags.
>
That's much cleaner than trying to keep track of sequence creations and
really pretty harmless. I'll give that a go and see how it looks.
> Seems like simpler solution than building all the tracking code on the
> decoding side to me.
+1
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | wcting | 2016-03-02 07:25:24 | Re: redo failed in physical streaming replication while stopping the master server |
| Previous Message | Michael Paquier | 2016-03-02 06:52:20 | Re: [REVIEW]: Password identifiers, protocol aging and SCRAM protocol |