| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: access/parallel.h lacks PGDLLIMPORT |
| Date: | 2017-12-20 00:48:59 |
| Message-ID: | CAMsr+YFGwc1TLEFACm+PQ0Qq7-RT9YGgv0L__9JWxxuPijxxBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19 December 2017 at 23:24, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Dec 19, 2017 at 3:36 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> > I also think it is good to allow ParallelWorkerNumber to be used in
> > extensions. Attached is the patch for same. I think for other two we
> > should wait till there is really a good use case for them.
>
> I think waiting for a "really good" use case is too high a bar. I
> think we only need to think that there is a "reasonable" use case.
> Accordingly, I pushed a commit adding PGDLLIMPORT to both
> ParallelWorkerNumber and InitializingParallelWorker.
>
Especially since all non-static *functions* are exported unconditionally,
so it's not like we set a high bar for public API.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | leoaaryan | 2017-12-20 00:54:13 | Re: Statically linking ICU with Postgres |
| Previous Message | Craig Ringer | 2017-12-20 00:46:30 | Re: Using ProcSignal to get memory context stats from a running backend |