| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | John Lumby <johnlumby(at)hotmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: legitimacy of using PG_TRY , PG_CATCH , PG_END_TRY in C function |
| Date: | 2017-10-23 08:16:10 |
| Message-ID: | CAMsr+YExCJDjDBb=8C2Z41Wk1eTh0jFd3rBU6vUBQtBG196Wig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23 October 2017 at 08:30, John Lumby <johnlumby(at)hotmail(dot)com> wrote:
> All works but not perfectly -- at COMMIT, resource_owner issues
> relcache reference leak messages about relation scans not closed
> and also about snapshot still active. I guess that the CREATE has
> switched resource_owner and pushed a snapshot, but I did not
> debug in detail.
A lot more work is required than what's done pg PG_CATCH to return to
a queryable state. I've been down this path myself, and it's not fun.
Take a look at all the extra work done on the error handling path in
PostgresMain.
At some point I'd really like to expose that in a more general way so
it can be used from background workers. Right now AFAICS most
background workers have to cope with errors with a proc_exit(1) and
getting restarted to try again. Not ideal.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2017-10-23 08:20:14 | Re: legitimacy of using PG_TRY , PG_CATCH , PG_END_TRY in C function |
| Previous Message | Andrey Borodin | 2017-10-23 08:13:56 | Re: Allow GiST opcalsses without compress\decompres functions |