From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Subject: | Re: Document how to set up TAP tests for Perl 5.8.8 |
Date: | 2016-11-17 02:00:53 |
Message-ID: | CAMsr+YEmmS8XP8Oj6vu2J+TM3SP_AnjCL3k6TsOfk2FxaUXOkg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 17 November 2016 at 00:01, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
>> On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote:
>>> --- a/src/test/perl/README
>>> +++ b/src/test/perl/README
>>> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some example tests read the
>>> perldoc for the test modules, e.g.:
>>>
>>> perldoc src/test/perl/PostgresNode.pm
>>> +
>>> +Required Perl
>>> +-------------
>>> +
>>> +Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain
>>
>> Tests must run on Perl 5.8.0 and newer.
Why? We've always discussed 5.8.8 before. That's already a full 10 years old.
5.8.0 is from *2002*. Are you running any 15-year-old systems you
can't update to a *patch release* of the same perl major?
gendef.pl says it needs 5.8.0 or newer with "use 5.8.0" but that's the
only relevant thing I can find, and it's not relevant to the TAP tests
anyway.
BTW, here's my older approach, with a dockerfile, before I became
aware of perlbrew:
5.8.8 is in CentOS 5.
Debian Lenny (6) has 5.14.2 Wheezy (5) has 5.10. Etch (4) has 5.8.8.
Etch came out in early 2007. Even Sarge had 5.8.4.
Ubuntu 10.04 Lucid (old-lts) had 5.10.1-8ubuntu2 .
So unless we care about Debian 3 Sarge or source builds done more than
10 years ago, 5.8.8 is more than good enough.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2016-11-17 02:09:29 | Re: [HACKERS] Patch: Implement failover on libpq connect level. |
Previous Message | Tsunakawa, Takayuki | 2016-11-17 02:00:32 | Re: Patch: Implement failover on libpq connect level. |