| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> |
| Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: logical decoding of two-phase transactions |
| Date: | 2017-03-28 00:51:26 |
| Message-ID: | CAMsr+YEejpKLyn=76LcmkLJGbw_QFFxNJsq_WDwqN6Lurdr-EQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 28 March 2017 at 08:50, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> wrote:
>
>> On 28 Mar 2017, at 00:19, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> wrote:
>>
>> * It is actually doesn’t pass one of mine regression tests. I’ve added expected output
>> as it should be. I’ll try to send follow up message with fix, but right now sending it
>> as is, as you asked.
>>
>>
>
> Fixed. I forgot to postpone ReorderBufferTxn cleanup in case of prepare.
>
> So it pass provided regression tests right now.
>
> I’ll give it more testing tomorrow and going to write TAP test to check behaviour
> when we loose info whether prepare was sent to subscriber or not.
Great, thanks. I'll try to have some TAP tests ready.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2017-03-28 00:54:47 | Re: pgsql: Clean up Perl code according to perlcritic |
| Previous Message | Craig Ringer | 2017-03-28 00:50:56 | Re: logical decoding of two-phase transactions |