| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pageinspect function to decode infomasks |
| Date: | 2017-09-14 14:00:54 |
| Message-ID: | CAMsr+YERdL-KsgaTs=y42BQoram67CEOth7HW=qmWG55hJHEJA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14 September 2017 at 19:57, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
wrote:
>
> Are you planning to work on the review comments from Robert, Moon
> Insung and supply the new patch. I just had a quick glance into this
> mail thread (after a long time) and could understand Robert's concern
> till some extent. I think, he is trying to say that if a tuple is
> frozen (committed|invalid) then it shouldn't be shown as COMMITTED and
> INVALID together in fact it should just be displayed as FROZEN tuple.
Yes, I'd like to, and should have time for it in this CF.
My plan is to emit raw flags by default, so FROZEN would't be shown at all,
only COMMITTED|INVALID. If the bool to decode combined flags is set, then
it'll show things like FROZEN, and hide COMMITTED|INVALID. Similar for
other combos.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-09-14 14:01:42 | Re: Parallel Hash take II |
| Previous Message | Alexander Korotkov | 2017-09-14 13:42:38 | Re: Allow GiST opcalsses without compress\decompres functions |