Re: [PATCH] PostgresNode.pm enhancements, pg_lsn helper, and some more recovery tests

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: [PATCH] PostgresNode.pm enhancements, pg_lsn helper, and some more recovery tests
Date: 2017-01-03 04:36:27
Message-ID: CAMsr+YE5hV2Mt30ztx6PkgjDYt4KgRmwpJ_aOvcswTmCGEW-oA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2 January 2017 at 20:17, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:

> Bit confused... can't see a caller for wait_for_slot_catchup() and the
> slot tests don't call it AFAICS.

The recovery tests for decoding on standby will use it. I can delay
adding it until then.

> Also can't see anywhere the LSN stuff is used either.

Removed after discussion with Michael in the logical decoding on standby thread.

I'll be posting a new patch series there shortly, which removes
pg_lsn.pm and modifies the PostgresNode.pm changes per discussion. If
you're able to commit the updated PostgresNode.pm and new standby
tests that'd be very handy.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-01-03 05:06:42 Re: Add support to COMMENT ON CURRENT DATABASE
Previous Message Pavan Deolasee 2017-01-03 04:13:38 Re: Patch: Write Amplification Reduction Method (WARM)