| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: [PATCH] Off-by-one error in logical slot resource retention |
| Date: | 2017-03-09 03:18:30 |
| Message-ID: | CAMsr+YE5D=_cD3TJmYipzB9-mXCE8b9uO6fcr9HbN__H1hh2jQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9 March 2017 at 11:17, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> Hi all
>
> I've found a minor off-by-one error in the resource retention logic
> for logical slots, where we treat confirmed_flush as meaning "flushed
> up to and including this LSN". Seems reasonable, but the rest of the
> code treats it as "flushed up to but excluding this LSN". In
> particular, we treat confirmed_flush as the inclusive startpoint for a
> new logical decoding session if no startpoint is provided by the
> client and will replay a change whose commit record begins at exactly
> confirmed_flush to the client.
This should be backpatched to 9.4.
The others do not need backpatching.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Okano, Naoki | 2017-03-09 04:00:32 | Re: Adding the optional clause 'AS' in CREATE TRIGGER |
| Previous Message | Roman Shaposhnik | 2017-03-09 03:18:04 | [PATCH] Enabling atomics on ARM64 |