| From: | Isaac Morland <isaac(dot)morland(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Getting rid of aggregate_dummy() |
| Date: | 2020-11-02 13:26:44 |
| Message-ID: | CAMsGm5dOMcipAwJS3rd+_TNRQtZzZ_WCziVdPreXXoAU+v63yw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 1 Nov 2020 at 15:47, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Anyway, this saves about 3KB in fmgrtab.o, without any downside
> that I can see. If someone accidentally called an aggregate as
> a normal function, they'd now get a different error message,
> namely "internal function "aggregate_dummy" is not in internal lookup
> table" instead of "aggregate function NNN called as normal function".
> That doesn't really seem like a problem.
>
Speaking as somebody who sometimes does really dumb things, I don’t like
this change in error message. The current message clearly identifies the
problem; the new message makes it look like there is a bug in Postgres.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-11-02 13:38:31 | Re: Collation versioning |
| Previous Message | Magnus Hagander | 2020-11-02 13:23:35 | Re: Prevent printing "next step instructions" in initdb and pg_upgrade |