| From: | CharSyam <charsyam(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS][PATCH] adding simple sock check for windows |
| Date: | 2018-03-31 12:38:55 |
| Message-ID: | CAMrLSE7Sy1erv+QuyBRDoGXQzp2Jv7dtT_tkBqk8Xi2fcO9i4g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks Amit.
I had a mistake. Thank you again to point it out :)
2018-03-31 19:33 GMT+09:00 Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>:
> On Sat, Mar 31, 2018 at 12:05 PM, CharSyam <charsyam(at)gmail(dot)com> wrote:
>> Amit, I agree with you.
>>
>> I changed my patch :) to remove old check.
>>
>
> - if (slot->sock < 0)
> + if (slot->sock == PGINVALID_SOCKET || slot->sock < 0)
>
> I still see the same check. I think by mistake you have attached old patch.
>
> --
> With Regards,
> Amit Kapila.
> EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| simple_check.patch | application/octet-stream | 455 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2018-03-31 12:54:05 | Re: [PATCH] Verify Checksums during Basebackups |
| Previous Message | Amit Kapila | 2018-03-31 12:13:58 | Re: Problem while setting the fpw with SIGHUP |