| From: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix recovery connection detail in EXEC_BACKEND builds |
| Date: | 2026-10-18 07:35:05 |
| Message-ID: | CAMm1aWZc0JN_SGSmK8ezvX6qzfapC0h3G8Nti9ixYA_1Uey9OQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Attached is v2 of the patch.
As suggested by Heikki, this version distinguishes the recovery states
using CAC_state instead of passing reachedConsistency separately
through BackendStartupData.
The patch restores CAC_NOTCONSISTENT and uses CAC_NOTHOTSTANDBY when
hot standby is enabled and consistency has been reached, but the
recovery snapshot is not yet ready. The backend can therefore select
the appropriate DETAIL and HINT directly from CAC_state without
relying on inherited process-local state.
I tested this on Linux with both normal and EXEC_BACKEND builds, and
the tests passed. I have not tested it on Windows.
Please review and share your feedback.
Best Regards,
Nitin Jadhav
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-fix-recovery-connection-detail-in-exec-backend-builds.patch | application/octet-stream | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Alexander Lakhin | 2026-10-18 07:00:00 | Re: pgstat: allow a stats kind to use its own dedicated dsa/dshash |