Improve GetConfigOptionValues function

From: Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Improve GetConfigOptionValues function
Date: 2023-01-18 07:51:05
Message-ID: CAMm1aWYgfekpRK-Jz5=pM_bV+Om=ktGq1vxTZ_dr1Z6MV-qokA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

GetConfigOptionValues function extracts the config parameters for the
given variable irrespective of whether it results in noshow or not.
But the parent function show_all_settings ignores the values parameter
if it results in noshow. It's unnecessary to fetch all the values
during noshow. So a return statement in GetConfigOptionValues() when
noshow is set to true is needed. Attached the patch for the same.
Please share your thoughts.

Thanks & Regards,
Nitin Jadhav

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nitin Jadhav 2023-01-18 07:53:30 Re: Improve GetConfigOptionValues function
Previous Message Bharath Rupireddy 2023-01-18 07:26:06 Deduplicate logicalrep_read_tuple()