| From: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | miyake_kouta <miyake_kouta(at)oss(dot)nttdata(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] psql : Improve code for help option |
| Date: | 2021-03-03 08:05:04 |
| Message-ID: | CAMm1aWYPqR_a6nvyF_DTYDH8GkBwe-HvnmdYy_pgCJWHxatwXw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I have reviewed the patch and it looks good to me.
Thanks and Regards,
Nitin Jadhav
On Wed, Mar 3, 2021 at 1:09 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
wrote:
>
>
> On 2021/03/03 12:27, miyake_kouta wrote:
> > 2021-03-03 00:09, Fujii Masao wrote:
> >> We can simplify the code more and remove "env = user"
> >> by just using "user" instead of "env" in the above?
> >
> > Thank you for your comment.
> > I updated my patch and replaced "env" with "user".
> > Please check.
>
> Thanks for updating the patch!
> LGTM. Barrying any objection, I will commit this patch.
>
> Regards,
>
> --
> Fujii Masao
> Advanced Computing Technology Center
> Research and Development Headquarters
> NTT DATA CORPORATION
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2021-03-03 08:08:00 | Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. |
| Previous Message | Fujii Masao | 2021-03-03 07:39:01 | Re: [PATCH] psql : Improve code for help option |