From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE |
Date: | 2012-01-22 05:48:19 |
Message-ID: | CAMkU=1zikKshn6X96SHjWeUB3g32B6EthBzPH1DggkzWaay_1A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Jan 21, 2012 at 9:05 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Sat, Jan 21, 2012 at 08:04:20PM -0800, Jeff Janes wrote:
>> This is failing "make check" for me.
>>
>>
>> *** /tmp/foo/src/test/regress/expected/alter_table.out Sat Jan 21 19:51:46 2012
>> --- /tmp/foo/src/test/regress/results/alter_table.out Sat Jan 21 19:54:18 2012
>> ***************
>> *** 1662,1667 ****
>> --- 1662,1668 ----
>> NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index
>> "norewrite1_parent_pkey" for table "norewrite1_parent"
>> DEBUG: building index "norewrite1_parent_pkey" on table "norewrite1_parent"
>> CREATE TABLE norewrite1_child(c text REFERENCES norewrite1_parent);
>> + DEBUG: building index "pg_toast_41491_index" on table "pg_toast_41491"
>> ALTER TABLE norewrite1_child ALTER c TYPE varchar; -- recheck FK
>> DEBUG: validating foreign key constraint "norewrite1_child_c_fkey"
>> CREATE DOMAIN other_int AS int;
>
> Thanks. I've attached a new version fixing this problem.
Thanks, I've verified that it now passes make check.
Looking at the code now, I don't think I'll be able to do a meaningful
review in a reasonable time. I'm not familiar with that part or the
code, and it is too complex for me to learn right now.
Cheers,
Jeff
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2012-01-22 09:28:25 | Re: JSON for PG 9.2 |
Previous Message | Peter Geoghegan | 2012-01-22 05:30:02 | Next steps on pg_stat_statements normalisation |