Re: Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE

From: Noah Misch <noah(at)leadboat(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Avoid FK validations for no-rewrite ALTER TABLE ALTER TYPE
Date: 2012-01-22 05:05:31
Message-ID: 20120122050531.GA15693@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 21, 2012 at 08:04:20PM -0800, Jeff Janes wrote:
> This is failing "make check" for me.
>
>
> *** /tmp/foo/src/test/regress/expected/alter_table.out Sat Jan 21 19:51:46 2012
> --- /tmp/foo/src/test/regress/results/alter_table.out Sat Jan 21 19:54:18 2012
> ***************
> *** 1662,1667 ****
> --- 1662,1668 ----
> NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index
> "norewrite1_parent_pkey" for table "norewrite1_parent"
> DEBUG: building index "norewrite1_parent_pkey" on table "norewrite1_parent"
> CREATE TABLE norewrite1_child(c text REFERENCES norewrite1_parent);
> + DEBUG: building index "pg_toast_41491_index" on table "pg_toast_41491"
> ALTER TABLE norewrite1_child ALTER c TYPE varchar; -- recheck FK
> DEBUG: validating foreign key constraint "norewrite1_child_c_fkey"
> CREATE DOMAIN other_int AS int;

Thanks. I've attached a new version fixing this problem.

Attachment Content-Type Size
at-foreign-key-v3.patch text/plain 16.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2012-01-22 05:23:55 Re: Second thoughts on CheckIndexCompatible() vs. operator families
Previous Message Jeff Janes 2012-01-22 04:40:30 Re: JSON for PG 9.2