psql's \watch is broken

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: psql's \watch is broken
Date: 2019-12-13 19:43:31
Message-ID: CAMkU=1zpoUDGKqWKuMWkj7t-bOCaJDx0r=5te_-d0B2HVLABXg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

If I do something like this:

explain (analyze) select * from pgbench_accounts \watch 1

It behaves as expected. But once I break out of the loop with ctrl-C, then
if I execute the same thing again it executes the command once, but shows
no output and doesn't loop. It seems like some flag is getting set with
ctrl-C, but then never gets reset.

It was broken in this commit:

commit a4fd3aa719e8f97299dfcf1a8f79b3017e2b8d8b
Author: Michael Paquier <michael(at)paquier(dot)xyz>
Date: Mon Dec 2 11:18:56 2019 +0900

Refactor query cancellation code into src/fe_utils/

I've not dug into code itself, I just bisected it.

Cheers,

Jeff

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-12-13 20:02:26 Re: Rearranging ALTER TABLE to avoid multi-operations bugs
Previous Message Tom Lane 2019-12-13 19:16:41 Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes