Re: PITR potentially broken in 9.2

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PITR potentially broken in 9.2
Date: 2012-12-05 02:14:04
Message-ID: CAMkU=1ynR4pvsoBi9TLMnEK1uinvFT=NoqYraPyXW8zcpAwWLw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Dec 4, 2012 at 4:35 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> So apparently this is something we broke since Nov 18. Don't know what
>> yet --- any thoughts?
>
> Further experimentation shows that reverting commit
> ffc3172e4e3caee0327a7e4126b5e7a3c8a1c8cf makes it work. So there's
> something wrong/incomplete about that fix.

I can't independently vouch for the correctness of that fix, but I can
vouch that there is so far no evidence that it is incorrect.

It is re-revealing an undesirable (but safe, as far as we know)
behavior that is present in 9.1.x but which was temporarily hidden by
a corruption-risk bug in 9.2.0 and 9.2.1.

>
> This is a bit urgent since we now have to consider whether to withdraw
> 9.2.2 and issue a hasty 9.2.3. Do we have a regression here since
> 9.2.1, and if so how bad is it?

I don't think this is urgent. The error-message issue in 9.1.6 and
9.2.2 is merely annoying, while the early-opening one in 9.2.0 and
9.2.1 seems fundamentally unsafe.

Cheers,

Jeff

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2012-12-05 02:15:38 Re: PITR potentially broken in 9.2
Previous Message Andres Freund 2012-12-05 02:07:22 Re: PITR potentially broken in 9.2

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2012-12-05 02:15:38 Re: PITR potentially broken in 9.2
Previous Message Andres Freund 2012-12-05 02:07:22 Re: PITR potentially broken in 9.2