Re: patch: avoid heavyweight locking on hash metapage

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch: avoid heavyweight locking on hash metapage
Date: 2012-06-26 03:05:52
Message-ID: CAMkU=1yU51ehsEDAQcUki4rHiY_0apzW3S+ej5W1MQBBnD7HyQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 18, 2012 at 5:42 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> Hmm.  That was actually a gloss I added on existing code to try to
> convince myself that it was safe; I don't think that the changes I
> made make that any more or less safe than it was before.

Right, sorry. I thought there was some strength reduction going on
there as well.

Thanks for the various explanations, they address my concerns. I see
that v2 applies over v1.

I've verified performance improvements using 8 cores with my proposed
pgbench -P benchmark, with a scale that fits in shared_buffers.
It brings it most of the way, but not quite, up to the btree performance.

I've marked this as ready for committer.

Cheers,

Jeff

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Satoshi Nagayasu 2012-06-26 03:10:11 Re: pg_stat_lwlocks view - lwlocks statistics
Previous Message Satoshi Nagayasu 2012-06-26 02:58:24 Re: pg_stat_lwlocks view - lwlocks statistics