Re: Turning off HOT/Cleanup sometimes

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Turning off HOT/Cleanup sometimes
Date: 2015-03-09 17:36:07
Message-ID: CAMkU=1yMVSud_V-dHfYWkJHXR8-Jh7h-QYObJ5Pv-36hy0BTWA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 17, 2014 at 12:39 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:

> On 15 December 2014 at 20:26, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>
> > I still get the compiler error in contrib:
> >
> > pgstattuple.c: In function 'pgstat_heap':
> > pgstattuple.c:279: error: too few arguments to function
> > 'heap_beginscan_strat'
> >
> > Should it pass false for the always_prune?
>
> Yes.
>
> New version attached.
>

This no longer applies directly against head, but if I apply to an older
checkout and then do "git checkout -m origin" it rolls forward cleanly.

Did versions 7 and 8 of this patch address Andres' concern about
performance regressions?

Thanks,

Jeff

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2015-03-09 17:37:44 Re: Calling for a replacement committer for GROUPING SETS
Previous Message Greg Stark 2015-03-09 17:33:23 Re: Rethinking the parameter access hooks for plpgsql's benefit