Re: [PATCH v2] GSSAPI encryption support

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Robbie Harwood <rharwood(at)redhat(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH v2] GSSAPI encryption support
Date: 2015-10-28 16:34:31
Message-ID: CAMkU=1y9Dj8nrhOizsE860JcqrWErq_aTJ-Z_qpmXxAJDu8Byw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 29, 2015 at 7:53 AM, Robbie Harwood <rharwood(at)redhat(dot)com> wrote:
> Robbie Harwood <rharwood(at)redhat(dot)com> writes:
>
>>>>> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>>>>>
>>>>>> Well, the issue is still here: login through gssapi fails with
>>>>>> your patch, not with HEAD. This patch is next on my review list by
>>>>>> the way so I'll see what I can do about it soon even if I am in
>>>>>> the US for Postgres Open next week. Still, how did you test it? I
>>>>>> am just creating by myself a KDC, setting up a valid credential
>>>>>> with kinit, and after setting up Postgres for this purpose the
>>>>>> protocol communication just fails.
>>
>> I have no issues, no sync loss; nothing is amiss as far as I can see.
>> If there is actually a problem here, I need more information from you.
>> At the very least, as previously mentioned, I need to know what
>> messages went over the wire to/from the server before it occurred, and
>> what command (if it it made it to command processing) it was in the
>> midst of sending.
>
> Any follow-up on this? I'd really like my code to be bug-free.

I don't know if this is worth posting as the patch is currently
returned with feedback and you are redoing it in a different way, but
with your patch I get this error when connecting:

lost synchronization with server: got message type "T", length 27
The connection to the server was lost. Attempting reset: Failed.

I only get the error when connection to a patched server from a
patched libpq. If either is unpatched, then there is no problem.

Let me know if this is worth looking into.

Cheers,

Jeff

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Tiikkaja 2015-10-28 16:50:19 onlyvalue aggregate (was: First Aggregate Funtion?)
Previous Message Jeff Janes 2015-10-28 16:26:04 Re: quieting DEBUG3