| From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add transforms feature |
| Date: | 2015-04-28 16:47:08 |
| Message-ID: | CAMkU=1xOFVqzE=fgejMnf=1bOnOtGUjQhKUV6220dDWxpj=pkg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 7, 2015 at 7:55 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On 3/22/15 5:46 AM, Pavel Stehule wrote:
> > Isn't better doesn't support "TRANSFORM ALL" clause? If somebody would
> > to use transformations - then he have to explicitly enable it by
> > "TRANSFORM FOR TYPE" ? It is safe and without possible user
> unexpectations.
>
> Following our off-list conversation, here is a new patch that removes
> the TRANSFORM ALL/NONE clauses and requires an explicit list.
>
Hi Peter,
This commit is causing a compiler warning for me in non-cassert builds:
funcapi.c: In function 'get_func_trftypes':
funcapi.c:890: warning: unused variable 'procStruct'
Adding PG_USED_FOR_ASSERTS_ONLY seems to fix it.
Cheers,
Jeff
| Attachment | Content-Type | Size |
|---|---|---|
| transform_unused.patch | application/octet-stream | 629 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-04-28 16:50:07 | Re: INSERT ... ON CONFLICT syntax issues |
| Previous Message | Peter Geoghegan | 2015-04-28 16:45:41 | Re: INSERT ... ON CONFLICT syntax issues |