| From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | compiler warning in pgcrypto imath.c |
| Date: | 2019-03-23 00:20:53 |
| Message-ID: | CAMkU=1x8taZfsbPkv_MsWbTtzibW_yQHXoMhF_DTtm=z2hVHDg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
When compiling on an AWS 64 bit Arm machine, I get this compiler warning:
imath.c: In function 's_ksqr':
imath.c:2590:6: warning: variable 'carry' set but not used
[-Wunused-but-set-variable]
carry;
^~~~~
With this version():
PostgreSQL 12devel on aarch64-unknown-linux-gnu, compiled by gcc
(Ubuntu/Linaro 7.3.0-27ubuntu1~18.04) 7.3.0, 64-bit
The attached patch adds PG_USED_FOR_ASSERTS_ONLY to silence it. Perhaps
there is a better way, given that we want to change imath.c as little as
possible from its upstream?
Cheers,
Jeff
| Attachment | Content-Type | Size |
|---|---|---|
| pgcrypto_warning.patch | application/octet-stream | 762 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-03-23 01:20:16 | Re: compiler warning in pgcrypto imath.c |
| Previous Message | Michael Paquier | 2019-03-22 23:57:36 | Re: Offline enabling/disabling of data checksums |