| From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
|---|---|
| To: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: Covering + unique indexes. |
| Date: | 2016-01-21 22:35:38 |
| Message-ID: | CAMkU=1wyUvAYgHu_o-_EePHw-7sda=c8Mm2Kh4mKZr6j+oKtjg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 19, 2016 at 9:08 AM, Anastasia Lubennikova
<a(dot)lubennikova(at)postgrespro(dot)ru> wrote:
>
>
> 18.01.2016 01:02, David Rowley пишет:
>
> On 14 January 2016 at 08:24, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
> wrote:
>>
>> I will try to review the omit_opclass_4.0.patch soon.
>
>
> Hi, as promised, here's my review of the omit_opclass_4.0.patch patch.
>
> Thank you again. All mentioned points are fixed and patches are merged.
> I hope it's all right now. Please check comments one more time. I rather
> doubt that I wrote everything correctly.
Unfortunately there are several merge conflicts between your patch and
this commit:
commit 65c5fcd353a859da9e61bfb2b92a99f12937de3b
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Date: Sun Jan 17 19:36:59 2016 -0500
Restructure index access method API to hide most of it at the C level.
Can you rebase past that commit?
Thanks,
Jeff
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2016-01-21 22:47:26 | Re: WIP: Covering + unique indexes. |
| Previous Message | Tomasz Rybak | 2016-01-21 22:13:37 | Re: pglogical_output - a general purpose logical decoding output plugin |