Re: Patch: Auto-generate search_path statement for selected schema in query editor

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Florian Klaar <flo(dot)klaar(at)gmx(dot)de>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Auto-generate search_path statement for selected schema in query editor
Date: 2013-03-28 12:04:35
Message-ID: CAMcbDBGgz4otguOpw62bxBp-XhpGjPzM9rgSkZGiPgdOBcZBbg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

I looked in the code and attached is the updated patch.

I have tested with my environment and it is not crashing and also now
"output pane" and "scratch pad" will not shown on GDB pane.

Please verify at your end for both the issues and let me know if any
modification is required.

Thanks,
Neel Patel

On Tue, Mar 26, 2013 at 2:12 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>wrote:

> Hi Dave,
>
> I will check and let you know.
>
> Thanks,
> Neel Patel
>
>
> On Tue, Mar 26, 2013 at 12:22 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Mon, Mar 25, 2013 at 9:02 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>> wrote:
>> > Hi Dave,
>> >
>> > Please find the attached new patch file for fix. I have tested in
>> Windows,
>> > debug build, VC++ 2010.
>> > After this fix i have continuously tested it with half an hour to
>> reproduce
>> > the crash but i am not able to reproduce it.
>> >
>> > Can you please test and check wether crash is again reproducible at your
>> > end.
>> >
>>
>> The crash isn't there any more, but it behaves differently now - the
>> scratch pad and the output pane are now shown on the GQB pane, whereas
>> they're not in the existing code - they get automatically hidden. That
>> causes a further problem (aside from the lack of space) - if you try
>> to grab the sash between the GQB and the output pane, the top tab set
>> switches back to the main query text pane.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

Attachment Content-Type Size
NewPagadminCrash.patch application/octet-stream 906 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dinesh Kumar 2013-04-03 13:53:23 Submitting a trivial pgAdmin 9.3 compatible patch
Previous Message Neel Patel 2013-03-26 08:42:38 Re: Patch: Auto-generate search_path statement for selected schema in query editor