| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Killing off removed rels properly |
| Date: | 2023-02-13 09:57:49 |
| Message-ID: | CAMbWs4_zhe22XqurMdcTx0PpSovHnCJSii3LXiutF_Hpdb9bxg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Feb 11, 2023 at 4:50 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I think it's time to clean this up by removing the rel from the
> planner data structures altogether. The attached passes check-world,
> and if it does trigger any problems I would say that's a clear
> sign of bugs elsewhere.
+1. The patch looks good to me. One minor comment is that we should
also remove the comments about RELOPT_DEADREL in pathnodes.h.
* Lastly, there is a RelOptKind for "dead" relations, which are base rels
* that we have proven we don't need to join after all.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-02-13 10:21:25 | Re: Time delayed LR (WAS Re: logical replication restrictions) |
| Previous Message | Kyotaro Horiguchi | 2023-02-13 09:33:34 | Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes? |