| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Assert failure in try_nestloop_path() |
| Date: | 2026-09-08 14:43:02 |
| Message-ID: | CAMbWs4_wWrUbCTnPZz_D7CJCXoj+AeQN9-nqrcvYGzPV0g_--w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 8, 2026 at 11:08 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I think the find_clause_by_serial tests are just clutter, really.
Yeah, we can drop it, along with the two Assert(equal(...)) checks
that used it. I'd added it only to increase my confidence that I
understood the situation correctly.
> Also, why is the last code hunk in get_joinrel_parampathinfo
> commented out?
Because without your drop-redundant-equivalence-clauses patch the
clause-recovery pass for dropped ECs re-adds a clause and trips that
Assert (the cardinal_number query). It needs to be un-commented once
your fix gets applied.
- Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-09-08 14:45:56 | Re: Assert failure in try_nestloop_path() |
| Previous Message | Andrey Kazarinov | 2026-09-08 14:19:21 | Re: [PATCH] Allow subquery pull-up past inlineable CTEs |