Re: Crash after a call to pg_backup_start()

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Crash after a call to pg_backup_start()
Date: 2022-10-21 09:53:25
Message-ID: CAMbWs4_ZhZm0iWcj0-fhUAMLGccyRoXG5aTnAhVNwDkaYgnMXg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 21, 2022 at 3:10 PM Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
wrote:

> It seems to me that the comment is true and the condition is a thinko.

Yeah, the two conditions could be both false. How about we update the
comment a bit to emphasize this? Such as

/* At most one of these conditions can be true */
or
/* These conditions can not be both true */

> Please find the attached fix.

+1

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2022-10-21 10:05:18 Re: parse partition strategy string in gram.y
Previous Message Ants Aasma 2022-10-21 09:48:36 Re: Standby recovers records from wrong timeline