Re: Fix a wrong comment in setrefs.c

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix a wrong comment in setrefs.c
Date: 2023-11-03 06:10:45
Message-ID: CAMbWs4_Pe4F8mHr8LKvBjH32GRW0cP-2TCCLdwuH+5K-oDr8pQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 26, 2023 at 9:51 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:

> On Tue, Sep 26, 2023 at 5:45 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
>> I'm inclined to write the comment more like "Usually the equal()
>> check is redundant, but in setop plans it may not be, since
>> prepunion.c assigns ressortgroupref equal to the column resno
>> without regard to whether that matches the topmost level's
>> sortgrouprefs and without regard to whether any implicit coercions
>> are added in the setop tree. We might have to clean that up someday;
>> but for now, just ignore any false matches."
>
>
> +1. It explains the situation much more clearly and accurately.
>

To make it easier to review, I've updated the patch to be so.

Thanks
Richard

Attachment Content-Type Size
v2-0001-Fix-a-wrong-comment-in-setrefs.c.patch application/octet-stream 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2023-11-03 06:19:03 Inconsistent use of "volatile" when accessing shared memory?
Previous Message Alexander Lakhin 2023-11-03 06:00:00 Re: Three commit tips