Re: Wrong results due to missing quals

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Wrong results due to missing quals
Date: 2023-05-25 06:36:31
Message-ID: CAMbWs4_G4WLjowfDcY2DzYAM-H6ViXk6YJ3Yas5W_CG3NdpvvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 25, 2023 at 5:28 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> I tried this and it seems to work all right: it fixes the example
> you showed while not causing any new failures. (Doesn't address
> the broken join-removal logic you showed in the other thread,
> though.)
>
> While at it, I also changed make_restrictinfo to treat has_clone
> and is_clone as first-class citizens, to fix the dubious coding in
> equivclass.c that I mentioned at [1].

The "incompatible_relids" idea is a stroke of genius. I reviewed the
patch and did not find any problem. So big +1 to the patch.

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-05-25 06:49:12 Re: ALTER TABLE SET ACCESS METHOD on partitioned tables
Previous Message David Rowley 2023-05-25 05:57:25 Re: PG 16 draft release notes ready