Re: Eager aggregation, take 3

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tender Wang <tndrwang(at)gmail(dot)com>, Paul George <p(dot)a(dot)george19(at)gmail(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Subject: Re: Eager aggregation, take 3
Date: 2025-10-09 08:07:08
Message-ID: CAMbWs4_-sag-cAKrLJ+X+5njL1=oudk=+KfLmsLZ5a2jckn=kg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 9, 2025 at 10:49 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Wed, Oct 8, 2025 at 8:14 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > +-- Enable eager aggregation, which by default is disabled.
> > +SET enable_eager_aggregate TO on;
>
> > The above comment and command mismatch to my understanding from
> > looking at postgresql.conf.sample and guc_parameters.dat.

> Right. This GUC was disabled by default prior to v17, and this is a
> leftover from that. Will push a fix. Thanks for pointing it out!

I noticed an unnecessary header include in initsplan.c. Will fix that
as well.

- Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2025-10-09 08:07:21 Re: Optimize LISTEN/NOTIFY
Previous Message Peter Smith 2025-10-09 08:05:24 Re: pg_createsubscriber --dry-run logging concerns