Re: ERROR: failed to assign all NestLoopParams to plan nodes

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ERROR: failed to assign all NestLoopParams to plan nodes
Date: 2026-10-30 02:02:47
Message-ID: CAMbWs4_+2nu7wQ0sFpF2for-U2s4MpGDjiapSJ-FOcOg-74h8w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 13, 2026 at 7:05 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> The simplest fix I can think of is to also count the outer joins that
> the outer rels in scope have already computed as req_outer in
> create_nestloop_plan(), though this is another band-aid here. See
> 0001.

Pushed and back-patched to v18. v16 and v17 have the same bug, but
the fix there would have to be a new join-order restriction in
have_dangerous_phv(), since they can't compute the PHV in the
nestloop's outer side. A simple version of that changed plans that
work fine today, and I don't think a failure this rare is worth that
risk in the stable branches. So I left them alone. If someone hits
it there, we can revisit.

> The attached 0002 does that. It's not a bug fix, so it's for master
> only.

Pushed to master.

- Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-10-30 02:03:03 Re: bug: query returns different result with and without memoization.
Previous Message Ayoub Kazar 2026-10-30 01:57:21 Re: O(N^3) planning time in choose_plan_name() since 8c49a484e8e