| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Issue with query_is_distinct_for() and grouping sets |
| Date: | 2025-10-23 02:44:54 |
| Message-ID: | CAMbWs49bc4JWn_f9AWFaouZUdurQCPeEmBwMEE-aJymY3UkFRg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 22, 2025 at 6:25 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> Attached is a patch along the lines of option #2. The LCOV report
> indicates that there is currently no test coverage for the "else if
> (query->groupingSets)" branch in query_is_distinct_for(). This patch
> also adds test cases to cover that branch.
Here is an updated patch that includes a commit message and adds a new
test case involving DISTINCT clause used with GROUP BY.
- Richard
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-distinctness-check-for-queries-with-grouping-.patch | application/octet-stream | 7.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-10-23 02:59:44 | Re: Issue with query_is_distinct_for() and grouping sets |
| Previous Message | Chao Li | 2025-10-23 02:43:13 | Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part |