Re: Eager aggregation, take 3

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Tender Wang <tndrwang(at)gmail(dot)com>
Cc: Radim Marek <radim(at)boringsql(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Eager aggregation, take 3
Date: 2026-06-03 01:25:01
Message-ID: CAMbWs49KSppYihVGz+c5uKJeRHtaG-a1wTG96d-ZMuEUmTO1Qw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 1, 2026 at 4:57 PM Tender Wang <tndrwang(at)gmail(dot)com> wrote:
> Richard Guo <guofenglinux(at)gmail(dot)com> 于2026年6月1日周一 15:19写道:
> > So I'd rather fix it in eager_aggregation_possible_for_relation, right
> > next to the existing outer-join check, by rejecting a relation that
> > lies on the inner side of a semijoin/antijoin. See attached.

> The attached LGTM.

Thanks for the review. Pushed.

And thanks to Radim for the report and the well-contained repro.

- Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-06-03 01:54:01 Re: Fix bug of CHECK constraint enforceability recursion
Previous Message Shinya Kato 2026-06-03 01:24:29 Re: Report oldest xmin source when autovacuum cannot remove tuples