| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Issue with query_is_distinct_for() and grouping sets |
| Date: | 2025-10-23 07:07:05 |
| Message-ID: | CAMbWs49HrvGcVqX7YBFkU0o9ev_-9Xq=PySUfv-4winKye_6fg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 23, 2025 at 1:33 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Thu, 23 Oct 2025 at 16:43, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > How about using the following wording in the commit message?
> >
> > "
> > The previous logic in query_is_distinct_for() was incomplete because
> > the check was insufficiently thorough and could return false when it
> > should have returned true.
> > "
> "it could" might be more accurate. The function is under no obligation
> to return true for every possible case.
Fair point. Patch updated with a revised commit message.
- Richard
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-distinctness-check-for-queries-with-grouping-.patch | application/octet-stream | 8.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-10-23 07:22:39 | Re: Tab completion for large objects |
| Previous Message | Alexander Lakhin | 2025-10-23 07:00:00 | Re: IO in wrong state on riscv64 |