Re: Issue with query_is_distinct_for() and grouping sets

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Issue with query_is_distinct_for() and grouping sets
Date: 2025-10-23 04:33:08
Message-ID: CAApHDvrD-=LgAzpSXtfHiPE22Cj04hM_otN2WwyXcXCtidk7eg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 23 Oct 2025 at 16:43, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> How about using the following wording in the commit message?
>
> "
> The previous logic in query_is_distinct_for() was incomplete because
> the check was insufficiently thorough and could return false when it
> should have returned true.
> "

"it could" might be more accurate. The function is under no obligation
to return true for every possible case.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2025-10-23 04:43:25 Re: doc: create table improvements
Previous Message Fujii Masao 2025-10-23 04:30:21 Re: Fix lag columns in pg_stat_replication not advancing when replay LSN stalls