Re: Clean up remove_rel_from_query() after self-join elimination commit

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: wenhui qiu <qiuwenhuifx(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Clean up remove_rel_from_query() after self-join elimination commit
Date: 2026-04-20 08:17:57
Message-ID: CAMbWs497f7moAjeHG2z+zFap1xkTf1wobkMs4m5SVmKQneenmQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 20, 2026 at 9:49 AM wenhui qiu <qiuwenhuifx(at)gmail(dot)com> wrote:
> > Assert(!is_outer_join || joinrelids != NULL);
>
> > Worth asserting. If a caller sets sjinfo but passes NULL for
> > joinrelids, this would silently over-delete PHVs.
> > Assert(!is_self_join || joinrelids == NULL);
>
> LGTM with the added assertion.

Thanks. Committed.

- Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-04-20 08:23:47 Re: Fix stats reporting delays in logical parallel apply worker
Previous Message Fujii Masao 2026-04-20 08:04:17 Re: Truncate logs by max_log_size