Re: Reduce "Var IS [NOT] NULL" quals during constant folding

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tender Wang <tndrwang(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Reduce "Var IS [NOT] NULL" quals during constant folding
Date: 2025-09-12 02:21:15
Message-ID: CAMbWs49=8hPqEbQjr6hTQp0R5s6Q8Js5XmMax0b-LdYXRnG=qA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 8, 2025 at 10:08 PM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
> On Mon, Sep 8, 2025 at 4:21 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > Your patch misses one spot: the notnullattnums in
> > get_relation_notnullatts() should also be fixed. Otherwise it LGTM.

> True, attached v2 adds that missing spot, thanks for the review.

Pushed. Thanks for the report and fix.

- Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2025-09-12 02:21:42 Re: PostgreSQL 18 GA press release draft
Previous Message Tom Lane 2025-09-12 02:12:59 Re: race condition in pg_class