Re: Compiling warnings on old GCC

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Compiling warnings on old GCC
Date: 2023-11-06 07:46:01
Message-ID: CAMbWs48b_8NUUdTPcL66jKNEvpMr+gzqsp7-g3bspfaG1sFTfw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 6, 2023 at 2:51 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:

> On Mon, 6 Nov 2023 at 19:14, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > I came across the following compiling warnings on GCC (Red Hat 4.8.5-44)
> > 4.8.5 with 'CFLAGS=-Og'
>
> > I wonder if this is worth fixing, maybe by a trivial patch like
> > attached.
>
> There's some relevant discussion in
> https://postgr.es/m/flat/20220602024243.GJ29853%40telsasoft.com

Ah, thanks for pointing that out. Somehow I failed to follow that
thread.

It seems that the controversial '-Og' coupled with the old GCC version
(4.8) makes it not worth fixing. So please ignore this thread.

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-11-06 07:50:46 Re: [PATCH] Small refactoring of inval.c and inval.h
Previous Message Andrey M. Borodin 2023-11-06 07:35:55 Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock