| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tender Wang <tndrwang(at)gmail(dot)com>, Paul George <p(dot)a(dot)george19(at)gmail(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Eager aggregation, take 3 |
| Date: | 2026-04-06 03:06:44 |
| Message-ID: | CAMbWs48Vt+8zL_hGOxg3V7Q9a1rsKisNxEz3R3verN6=FCEvUQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 2, 2026 at 9:18 PM Matheus Alcantara
<matheusssilv97(at)gmail(dot)com> wrote:
> The patches looks good to me and are working as expected. It seems very
> straightforward, so I don't have any major comments.
>
> I'm attaching some new tests that I've added to collate.icu.utf8 and
> eager_aggregate regression tests during my review, fell free to include
> any of them if it could be helpful or none.
Thanks for the review. I have added two of your test cases and
committed the patches.
- Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-04-06 03:14:06 | Re: Shmem allocated wrong for custom cumulative stats |
| Previous Message | Tom Lane | 2026-04-06 03:04:55 | Re: CREATE SCHEMA ... CREATE DOMAIN support |