Re: pgsql: Ignore PlaceHolderVars when looking up statistics

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Richard Guo <rguo(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Ignore PlaceHolderVars when looking up statistics
Date: 2026-01-05 00:52:12
Message-ID: CAMbWs48T3yV--m+KLszRhG1UK7acXMX9Y_UYPNt0k35oPdoZ2A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Jan 3, 2026 at 6:20 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > Generally we don't back-patch fixes that could change plans, because
> > it tends to produce user complaints. It's maybe more justifiable in
> > this case because v18 is quite new and you didn't back-patch to older
> > releases, but are we sure that it's warranted even there?

> It's a regression if we don't.

That's right. I was actually of two minds for a while regarding the
back-patch, but in the end decided to proceed. You can find the
discussions and the reasoning behind this decision in the link below.

https://postgr.es/m/CAMbWs49h5F66KZwLxaeXoLwHe_9jAB7Eu44UmJhhQpLA38tKhw@mail.gmail.com

- Richard

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2026-01-05 01:09:40 Re: pgsql: Remove unneeded defines from pg_config.h.in
Previous Message Michael Paquier 2026-01-05 00:49:26 Re: pgsql: Remove unneeded defines from pg_config.h.in

Browse pgsql-hackers by date

  From Date Subject
Next Message Alastair Turner 2026-01-05 01:03:51 Proposal - Enabling btree_gist by default
Previous Message Tom Lane 2026-01-05 00:46:15 Re: Typos in the code and README