Re: A structure has changed but comment modifications maybe missed

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, 甄明洋 <zhenmingyang(at)yeah(dot)net>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: A structure has changed but comment modifications maybe missed
Date: 2023-03-30 03:33:43
Message-ID: CAMbWs48OxZdRBb7i2eYvAdG+n5Vrh1Gx_DLw0RD=Y3gGunRU8A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Mar 30, 2023 at 11:07 AM Andres Freund <andres(at)anarazel(dot)de> wrote:

> On 2023-03-30 16:00:23 +1300, David Rowley wrote:
> > See the adjusted patch attached.
>
> Looks reasonable to me. We could try to reference TTS_SHOULDFREE(), without
> mentioning flags, instead - but I think your version is better.

+1.

Thanks
Richard

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message David Rowley 2023-03-30 03:37:39 Re: A structure has changed but comment modifications maybe missed
Previous Message Andres Freund 2023-03-30 03:07:40 Re: A structure has changed but comment modifications maybe missed