| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c |
| Date: | 2023-06-14 07:38:10 |
| Message-ID: | CAMbWs48KxbY9EzZSQBy-30Ey06H-+Bi4HcQvxrOvEHANSGQmVg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 14, 2023 at 1:07 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
wrote:
> On Wed, Jun 14, 2023 at 12:33 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
> > Hi, hackers
> >
> > We use (GUC_UNIT_MEMORY | GUC_UNIT_TIME) instead of GUC_UNIT even though
> we
> > already define it in guc.h.
> >
> > Maybe using GUC_UNIT is better? Here is a patch to fix it.
>
> Yeah, it seems more consistent with other places in guc.c. I'll push
> it, barring any objections.
+1. BTW, it seems that GUC_UNIT_TIME is not used anywhere except in
GUC_UNIT. I was wondering if we can retire it, but maybe we'd better
not. It still indicates that we need to use time units table.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-06-14 07:47:45 | Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c |
| Previous Message | Peter Eisentraut | 2023-06-14 07:37:45 | Re: pgindent vs. pgperltidy command-line arguments |