| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Tender Wang <tndrwang(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, runyuan(at)berkeley(dot)edu, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19046: Incorrect result when using json_array() with column reference in subquery combined with RIGHT JOIN |
| Date: | 2025-09-16 10:18:45 |
| Message-ID: | CAMbWs481xzHemAiwU366zZP6vVk2rkQcihgB5T0C582Mr=o8Bg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Sep 16, 2025 at 10:05 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> There may be other functions that should be treated as non-strict but
> currently aren't. For now, I suggest we address JsonConstructorExpr
> first. If we encounter more such cases later, they should be
> straightforward to fix as well.
I don't like the test cases in the proposed patch. First, the test
output is excessively large, resulting in a patch with over 30,000
insertions. I don't think it's a good idea to output the entire tenk1
table. Second, I don't think it's useful to test json_arrayagg or
json_objectagg. As I mentioned earlier, these are aggregates, so the
subquery wouldn't be pulled up in the first place.
I've rewritten the test cases, added a commit message, and pushed the
patch. It has also been back-patched to v16.
- Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2025-09-16 10:31:49 | Re: BUG #19046: Incorrect result when using json_array() with column reference in subquery combined with RIGHT JOIN |
| Previous Message | Tom Lane | 2025-09-16 02:08:40 | Re: BUG #18959: Name collisions of expression indexes during parallel Index creations on a pratitioned table. |