Re: Comment in preptlist.c

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Comment in preptlist.c
Date: 2023-03-21 10:02:39
Message-ID: CAMbWs4-vO9TzYOTgamxJgcXm9gcdYaKhOa=CnMenPJf7YP9hXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 21, 2023 at 5:41 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
wrote:

> While working on something else, I noticed $SUBJECT added by commit
> 86dc90056:
>
> * For UPDATE and DELETE queries, the targetlist must also contain "junk"
> * tlist entries needed to allow the executor to identify the rows to be
> * updated or deleted; for example, the ctid of a heap row. (The planner
> * adds these; they're not in what we receive from the planner/rewriter.)
>
> I think that “planner/rewriter” should be parser/rewriter. Attached
> is a patch for that.

Yes of course. It should be parser/rewriter here.

Thanks
Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ants Aasma 2023-03-21 10:03:21 Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode
Previous Message Alvaro Herrera 2023-03-21 09:59:20 Re: Commitfest 2023-03 starting tomorrow!