A spot of redundant initialization of brin memtuple

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: A spot of redundant initialization of brin memtuple
Date: 2021-11-19 07:43:14
Message-ID: CAMbWs4-kYYpKNOdiWtsCZ3jbkFFj4nhOVH22JH7dsrMYX=aGjg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Happened to notice this when reading around the codes. The BrinMemTuple
would be initialized in brin_new_memtuple(), right after being created.
So we don't need to initialize it again outside.

diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
index ccc9fa0959..67a277e1f9 100644
--- a/src/backend/access/brin/brin.c
+++ b/src/backend/access/brin/brin.c
@@ -1261,8 +1261,6 @@ initialize_brin_buildstate(Relation idxRel,
BrinRevmap *revmap,
state->bs_bdesc = brin_build_desc(idxRel);
state->bs_dtuple = brin_new_memtuple(state->bs_bdesc);

- brin_memtuple_initialize(state->bs_dtuple, state->bs_bdesc);
-
return state;
}

Thanks
Richard

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-11-19 07:50:58 Re: drop tablespace failed when location contains .. on win32
Previous Message Michael Paquier 2021-11-19 07:33:18 Re: CREATE tab completion