Update the comment in nodes.h to cover Cardinality

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Update the comment in nodes.h to cover Cardinality
Date: 2023-12-19 06:23:25
Message-ID: CAMbWs4-Zd7Yy80RL1NdskLLo-wz6QoqsbC5TKs=3yZxG3BT_aA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

By chance I discovered that the comment for the typedefs of "double"s
does not cover Cardinality. Should we update that comment accordingly,
maybe something like below?

- * Typedefs for identifying qualifier selectivities and plan costs as such.
- * These are just plain "double"s, but declaring a variable as Selectivity
- * or Cost makes the intent more obvious.
+ * Typedefs for identifying qualifier selectivities, plan costs and
+ * estimated rows or other count as such. These are just plain "double"s,
+ * but declaring a variable as Selectivity, Cost or Cardinality makes the
+ * intent more obvious.

Thanks
Richard

Attachment Content-Type Size
v1-0001-Add-comment-for-Cardinality-typedef.patch application/octet-stream 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2023-12-19 06:36:55 Re: "pgoutput" options missing on documentation
Previous Message Amit Kapila 2023-12-19 06:06:51 Re: Synchronizing slots from primary to standby