Re: Assert failure in try_nestloop_path()

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Tender Wang <tndrwang(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Assert failure in try_nestloop_path()
Date: 2026-09-09 01:38:41
Message-ID: CAMbWs4-S0eOh2+272thMykptq0ihznVZ=wyyTQ3i_SxnhAOh5g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 8, 2026 at 11:45 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Ah. Do you want to just merge those patches and push them as one?
> I think we want HEAD-and-19-only for all these changes.

Yes. I've merged the clone-dedup fix and your
drop-redundant-equivalence-clauses fix into a single patch (0001
attached), removed the find_clause_by_serial cross-checks, and
un-commented the assertion in get_joinrel_parampathinfo, which now
holds with your fix in place.

I've kept the create_join_clause change as a separate patch (0002),
since it's a distinct issue. There the trouble is that two
RestrictInfos for the same condition end up with different
rinfo_serials, rather than that we enforce multiple clones of the
same clause.

I plan to push both to HEAD and v19 but no further if there are no
objections.

- Richard

Attachment Content-Type Size
v2-0001-Fix-more-duplicate-qual-clauses-in-parameterized-.patch application/octet-stream 14.9 KB
v2-0002-Fix-duplicate-enforcement-of-EC-derived-condition.patch application/octet-stream 9.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-09-09 02:05:31 Re: pgbench: \gset and \aset should store SQL NULL as the null value
Previous Message shihao zhong 2026-09-09 01:20:29 Re: [PATCH] Planner support function for generate_subscripts()