| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | XueJing Zhao <zxuejing(at)vmware(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove useless param for create_groupingsets_path |
| Date: | 2022-06-15 04:12:00 |
| Message-ID: | CAMbWs4-MWaLEVyuAO24E4w9gcshUZHGHZVQ1fFPZoB6nccSRKw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 15, 2022 at 11:33 AM XueJing Zhao <zxuejing(at)vmware(dot)com> wrote:
> Recently I work on grouping sets and I find the last param numGroups of
> create_groupingsets_path is not used.
>
> In create_groupingsets_path we use rollup->numGroups to do cost_agg.
>
Yes indeed. The param 'numGroups' was used originally when we first
introduced in create_groupingsets_path(), and then all its references
inside that function were removed and replaced with the numGroups inside
RollupData in b5635948.
> I generate a diff.patch, which is sent as an attachment.
>
BTW, the patch looks weird to me that it seems operates in the inverse
direction, i.e. it's adding the param 'numGroups', not removing it.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-06-15 04:14:03 | Re: Remove trailing newlines from pg_upgrade's messages |
| Previous Message | Kyotaro Horiguchi | 2022-06-15 04:05:52 | Re: Remove trailing newlines from pg_upgrade's messages |