Re: Wrong results: NOT IN to anti-join with an upper-level Var in the sub-select's output

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Rui Zhao <zhaorui126(at)gmail(dot)com>
Cc: Tender Wang <tndrwang(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong results: NOT IN to anti-join with an upper-level Var in the sub-select's output
Date: 2026-08-03 07:07:15
Message-ID: CAMbWs4-HmZk53b0y+U1PSmb0Wb_Vy9sVCd4Ofpetw_qrp-wyaA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Aug 1, 2026 at 12:26 AM Rui Zhao <zhaorui126(at)gmail(dot)com> wrote:
> Thanks for looking. Moved the comment ahead of the test and left the one
> inside the if alone, as you suggested; v2 attached. make check is still green
> and the test still fails without the code change.

Thanks for the report and the patch!

The patch LGTM, except that the comment is overly verbose. Also I'd
prefer to reuse existing tables instead of creating new ones in the
test case.

I've made some tweaks and then pushed the patch.

- Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Shlok Kyal 2026-08-03 06:41:57 Re: Support EXCEPT for ALL SEQUENCES publications